ZLib compression overhaul #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes all use of 3rd-party compression libraries and instead uses new System.IO.Compression APIs (ZLibStream). ZLibStream re-compression does not produce a bit perfect assembly of a file but this does not(?) break either AIR or other disassembler and I consider that to be fine.
There was no replacement for LZMA but there is work and a lot of interest in adding such for .NET 7. As of writing this PR it's been given Priority 1 and is being tracked at dotnet/runtime#1542. The existing LZMA code was removed for now and will be added back with a big code overhaul by me or be whatever Microsoft will decide for the .NET 7 issue.
It also includes rewrite of DefineBitsLossLess tag handling and subsequently adds support for both versions of the tag. The job of decompressing the image data is given to the consumer of the tag in order to give support for different BitmapFormats and make it easier to write the tag back to file.