Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strings.sol according to latest compiler version #17

Merged
merged 1 commit into from
Oct 28, 2017

Conversation

chriseth
Copy link
Contributor

@chriseth chriseth commented Aug 1, 2017

No description provided.

Copy link

@danielscai danielscai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my latest complier is solidity 0.4.13 , and i change pragma solidiy ^0.4.13 .

and i got the error

 Jump instructions are low-level EVM features that can lead to incorrect stack access. Because of that they are discouraged. Please consider using "switch" or "for" statements instead.
                    jumpi(exit, eq(and(mload(ptr), mask), needledata))
                    ^---^
, 

@chriseth
Copy link
Contributor Author

chriseth commented Aug 7, 2017

@danielscai yes, this does not yet remove all warnings, but I would say it is an improvement.

@Arachnid
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants