Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve Arango DB version #411

Closed
msamoila opened this issue Aug 26, 2022 · 4 comments
Closed

Retrieve Arango DB version #411

msamoila opened this issue Aug 26, 2022 · 4 comments

Comments

@msamoila
Copy link

msamoila commented Aug 26, 2022

Sometimes the HTTP response body which did not succeed does not contain and ApiErrorResponse object serialized as JSON. In that case it would be useful to return the HTTP Status Code.

@msamoila msamoila changed the title Ability to add custom headers to HTTP request sent to Arango DB REST API Return HTTP Status Code in ApiErrorException if the HTTP response body is not a ApiErrorResponse JSON Aug 26, 2022
@msamoila
Copy link
Author

No time to fix.

@msamoila msamoila closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2022
@msamoila msamoila changed the title Return HTTP Status Code in ApiErrorException if the HTTP response body is not a ApiErrorResponse JSON Retrieve Arango DB version Aug 29, 2022
@msamoila
Copy link
Author

Retrieve Arango DB version

@msamoila msamoila reopened this Aug 29, 2022
@DiscoPYF DiscoPYF linked a pull request Sep 8, 2022 that will close this issue
@DiscoPYF
Copy link
Collaborator

DiscoPYF commented Sep 8, 2022

Closing as already implemented. See #417 (comment)

@DiscoPYF DiscoPYF closed this as completed Sep 8, 2022
@DiscoPYF
Copy link
Collaborator

DiscoPYF commented Sep 8, 2022

@msamoila I would recommend to open new issues instead of repurposing closed issues, for clarity. That way if any of them end up having discussions they are self contained with a clear history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants