Feature/Use Error Code As Enum #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossmills99
approved these changes
Nov 7, 2019
There was a problem hiding this comment.
I like, thanks for picking up on the idea that the ArangoDB errorNum field could be captured as enum.
One question I have, is the name ErrorCode right? Since ArangoDB responses call this errorNum, would it make sense to use the same nomenclature and call it ErrorNum or possibly ArangoDBErrorNum? @DiscoPYF any opinion?
|
Is there a convention for how we differentiate between an int and an enum? Otherwise, yes, agreed, we should keep the property name ErrorNum |
rossmills99
changed the title
rossmills99
changed the title
|
After some discussion we've decided not to merge this and continue using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12