Implement endpoint to list available users in UserApiClient. #288
Conversation
| [Fact] | ||
| public async Task GetUsersAsync_ShouldSucceed() | ||
| { | ||
| GetUsersResponse response = await _userClient.GetUsersAsync(); |
There was a problem hiding this comment.
Would make sense to test the case that we don't have admin access? Also that the users are indeed the number that we expect. Additionally, we could delete the users and catch the exception, not so important I assume.
There was a problem hiding this comment.
Regarding testing the admin case, the documentation says the following:
Fetches data about all users. You need the Administrate server access level in order to execute this REST call. Otherwise, you will only get information about yourself.
https://www.arangodb.com/docs/stable/http/user-management.html#list-available-users
In any cases, we get information back in an identical format. Here we just want to check that the endpoint and response are working properly rather than testing all cases, so I would say this test case is enough.
For the number of users, we don't know exactly what number of users to expect (e.g. tests are creating/deleting users), hence the check for Count() > 0 which I think is enough.
we could delete the users and catch the exception
Not sure what you mean. We already have tests to cover the delete scenario.
|
@modios @rossmills99 Thank you for reviewing. I will merge this and v1 should be good to go. |
fix #258
Implement remaining endpoint:
GET /_api/user/https://www.arangodb.com/docs/stable/http/user-management.html#list-available-users