-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream transaction on Document API #327
Stream transaction on Document API #327
Conversation
…d to the request headers. fix ArangoDB-Community#322
4bc1b30
to
1922279
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to see a test introduced to verify the TransactionId HeadDocumentHeader value is handled properly.
Can we move the x-arango-trx-id to a constant?
Moved the TransactionId header string to a constant class. fix ArangoDB-Community#322
PR updated to address the comments,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes look good! As discussed elsewhere, we need to annotate the new tests with [Trait("Feature", "StreamTransaction")]
so they are skipped in the 3.4 ArangoDB test run.
…o skip 3.4 ArangoDB test run. fix ArangoDB-Community#322
PR updated |
/// <returns></returns> | ||
Task<PostDocumentResponse<T>> PostDocumentAsync<T>( | ||
string collectionName, | ||
T document, | ||
PostDocumentsQuery query = null, | ||
ApiClientSerializationOptions serializationOptions = null); | ||
ApiClientSerializationOptions serializationOptions = null, | ||
HeadDocumentHeader headers = null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thing: we could rename HeadDocumentHeader
to DocumentHeader
or DocumentHeaderProperties
to be in line with CursorHeaderProperties
.
No description provided.