Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for analyzers #357

Merged
merged 13 commits into from
Apr 28, 2022
Merged

Support for analyzers #357

merged 13 commits into from
Apr 28, 2022

Conversation

tjoubert
Copy link
Contributor

@tjoubert tjoubert commented Apr 6, 2022

Added support for the Analyzers endpoints.
GET /_api/analyzer List all Analyzers
POST /_api/analyzer Create an Analyzer with the supplied definition
DELETE /_api/analyzer/{analyzer-name} Remove an Analyzer
GET /_api/analyzer/{analyzer-name} Return the Analyzer definition

Copy link
Collaborator

@DiscoPYF DiscoPYF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid contribution as always, thanks @tjoubert ! I left a few comments to clarify minor items, but happy to merge once discussed.

.circleci/config.yml Outdated Show resolved Hide resolved
@tjoubert
Copy link
Contributor Author

Hey @DiscoPYF, thanks a lot for your review. I have addressed all the issues.

Copy link
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments addressed and fixed. LGTM.

@Zyqsempai Zyqsempai merged commit 5f08f11 into ArangoDB-Community:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants