-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support basic Admin API #370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tjoubert 🥳 I left a bunch of comments but only one of them is a blocker in GetLogsQuery
.
I noticed a couple of endpoints from the online doc that have not been added here. Is that on purpose? e.g. GET /_admin/server/availability
Should the changelog file be updated? |
|
I will prefer to update the changelog and the roadmap files immediately after the merge so as to avoid conflicts when we have multiple PRs open. |
Thanks @DiscoPYF. Yes, there are a lot more Admin API endpoints. We're implementing a small subset for now to support features that we will implement very soon. |
Could you elaborate a bit on that? Features for this C# library or ArangoDB? Maybe creating issues where we paste a bit more context would help answer those questions beforehand. |
@DiscoPYF, yes we use another tool internally to track projects and issues. These endpoints had to be implemented to bring the C# driver up to date with our other drivers like Java and JS. In terms of future development, we have some ideas of tools that will be useful to the C# community but no firm development plan for these yet. For now, we're focused on supporting features from the ArangoDB API. |
GET/_admin/log/entries
Read global logs from the serverPOST/_admin/routing/reload
Reloads the routing informationGET/_admin/server/id
Return id of a server in a clusterGET/_admin/server/role
Return role of a server in a clusterGET/_api/engine
Return server database engine typeGET/_api/version
Return server version