Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support basic Admin API #370

Merged
merged 7 commits into from
May 16, 2022
Merged

Conversation

tjoubert
Copy link
Contributor

@tjoubert tjoubert commented May 2, 2022

GET/_admin/log/entries Read global logs from the server
POST/_admin/routing/reload Reloads the routing information
GET/_admin/server/id Return id of a server in a cluster
GET/_admin/server/role Return role of a server in a cluster
GET/_api/engine Return server database engine type
GET/_api/version Return server version

@tjoubert tjoubert requested a review from DiscoPYF May 2, 2022 07:48
Copy link
Collaborator

@DiscoPYF DiscoPYF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tjoubert 🥳 I left a bunch of comments but only one of them is a blocker in GetLogsQuery.

I noticed a couple of endpoints from the online doc that have not been added here. Is that on purpose? e.g. GET /_admin/server/availability

arangodb-net-standard/AdminApi/AdminApiClient.cs Outdated Show resolved Hide resolved
arangodb-net-standard/AdminApi/Models/GetLogsQuery.cs Outdated Show resolved Hide resolved
arangodb-net-standard/AdminApi/Models/ResponseBase.cs Outdated Show resolved Hide resolved
arangodb-net-standard/AdminApi/Models/EngineAlias.cs Outdated Show resolved Hide resolved
@DiscoPYF
Copy link
Collaborator

DiscoPYF commented May 8, 2022

Should the changelog file be updated?

@tjoubert
Copy link
Contributor Author

tjoubert commented May 9, 2022

@tjoubert tjoubert closed this May 9, 2022
@tjoubert tjoubert reopened this May 9, 2022
@tjoubert
Copy link
Contributor Author

tjoubert commented May 9, 2022

Should the changelog file be updated?

I will prefer to update the changelog and the roadmap files immediately after the merge so as to avoid conflicts when we have multiple PRs open.

@tjoubert
Copy link
Contributor Author

tjoubert commented May 9, 2022

Thanks @tjoubert 🥳 I left a bunch of comments but only one of them is a blocker in GetLogsQuery.

I noticed a couple of endpoints from the online doc that have not been added here. Is that on purpose? e.g. GET /_admin/server/availability

Thanks @DiscoPYF. Yes, there are a lot more Admin API endpoints. We're implementing a small subset for now to support features that we will implement very soon.

@DiscoPYF
Copy link
Collaborator

We're implementing a small subset for now to support features that we will implement very soon.

Could you elaborate a bit on that? Features for this C# library or ArangoDB? Maybe creating issues where we paste a bit more context would help answer those questions beforehand.
I see that all branches are created after a specific number. I suppose you have an issue tracker internally in the ArangoDB org?

@tjoubert
Copy link
Contributor Author

@DiscoPYF, yes we use another tool internally to track projects and issues. These endpoints had to be implemented to bring the C# driver up to date with our other drivers like Java and JS. In terms of future development, we have some ideas of tools that will be useful to the C# community but no firm development plan for these yet. For now, we're focused on supporting features from the ArangoDB API.

@tjoubert tjoubert merged commit 26bbb29 into master May 16, 2022
@tjoubert tjoubert deleted the feature-3.8/DE-202-basic-admin-endpoints branch May 16, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants