Added async serialization methods #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpoeter
approved these changes
Oct 27, 2022
DiscoPYF
reviewed
Nov 11, 2022
tjoubert
changed the title
I've made this change. |
tjoubert
added
the
breaking change
tjoubert
changed the title
DiscoPYF
reviewed
Nov 30, 2022
|
@DiscoPYF , I've made all the relevant changes. Will merge once you approve. |
DiscoPYF
reviewed
Dec 5, 2022
There was a problem hiding this comment.
I left a comment to consider before merging. But looks good otherwise.
As it is a breaking change in theory, we should hold off merging until after the next minor release? In practice, it may not affect many consumers, but we don't know who is using a customer serializer implementation.
tjoubert
deleted the
feature-3.8/DE-25-add-async-serialization-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #281