3.10: Query rules #413
Merged
3.10: Query rules #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiscoPYF
reviewed
Sep 16, 2022
arangodb-net-standard/AqlFunctionApi/Models/GetQueryRulesResponseItem.cs
Outdated
Show resolved
Hide resolved
arangodb-net-standard/AqlFunctionApi/Models/GetQueryRulesResponseFlags.cs
Outdated
Show resolved
Hide resolved
|
@DiscoPYF thanks for your review. I've made the relevant changes and looking forward to your approval. |
DiscoPYF
reviewed
Oct 12, 2022
| [Fact] | ||
| public async Task GetQueryRulesAsync_ShouldSucceed() | ||
| { | ||
| if (_fixture.VersionMajor >= 3 && _fixture.VersionMinor >= 10) |
There was a problem hiding this comment.
Should we implement this check using the ServerVersion Trait like here?
[Fact]
[Trait("ServerVersion", "3_10_PLUS")]
public async Task GetQueryRulesAsync_ShouldSucceed() { }Or was this meant to be a new approach?
Both approaches have pros and cons. The Trait one is more visible, but a bit cumbersome as we need to update the test command in the config file for each version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/arangodb/docs/blob/main/3.10/release-notes-api-changes310.md#optimizer-rules-for-aql-queries