3.10: Pregel API support with 3.10 features #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tjoubert
commented
Sep 26, 2022
tjoubert
commented
- Added Pregel API support, see https://www.arangodb.com/docs/stable/http/pregel.html
- Added new features in v3.10 for Pregel API, see https://github.com/arangodb/docs/blob/main/3.10/release-notes-api-changes310.md#pregel-api
DiscoPYF
force-pushed
the
feature-3-10
branch
from
35504b0
to
ec7b030
Compare
DiscoPYF
force-pushed
the
feature3.10/DE-353-pregel-api
branch
from
a428e04
to
06bec11
Compare
DiscoPYF
force-pushed
the
feature3.10/DE-353-pregel-api
branch
from
06bec11
to
f411ebc
Compare
DiscoPYF
reviewed
Oct 3, 2022
There was a problem hiding this comment.
Looks good overall. I left a few comments about missing properties and naming.
It would be good to have tests covering the new API (mainly to ensure serialization is working correctly), but from what I understand it's not trivial to setup as we need SmartGraphs (ArangoDB Enterprise).
We should create an issue to run tests against an Enterprise version of ArangoDB. Would you agree?
|
@DiscoPYF thanks for your review. I have made the relevant changes. I am also waiting on feedback from our core engineers and I will update the PregelApi section as and when I receive these feedback. I am looking forward to your approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.