Added ArangoDBErrors enum #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiscoPYF
approved these changes
Jan 16, 2023
There was a problem hiding this comment.
Looks good to me.
The name of the enums don't really follow the project's convention (PascalCase for enum fields), but at least they match ArangoDB's error codes so can be recognisable. Also probably easier to automate generating these.
Did you use any sort of automated script to add them? I wonder if we should open an issue to create a script that updates this file automatically, so that we can easily update it between ArangoDB releases.
|
@DiscoPYF, I did consider the project convention. However, I think it's better to leave the error code names exactly as defined by the server. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #424
Added an enum of ArangoDB errors.