Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #479 Add tests for ArangoDB 3.11. #486

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

rossmills99
Copy link
Collaborator

#479 Adds tests for ArangoDB 3.11

@rossmills99
Copy link
Collaborator Author

Interesting... appears to be a broken test which starts breaking with some minor version of 3.10.x (before these changes, the tests ran against 3.10.0 and worked fine. Now I've updated so they run on the most recent patch version, and one of them is failing).

Now trying to reproduce locally.

@rossmills99
Copy link
Collaborator Author

image

The documentation doesn't mention a "Code" property in the response. The failing test is checking the "Code" property for a match on HttpStatus.OK. However the value of "Code" property is no longer 200 (OK) but is 0. I expect some change was made and the code is not being set any more in the ArangoDB backend. Since it isn't a documented part of the API, I think just removing the check from the test is an appropriate course of action.

});

Assert.Equal(HttpStatusCode.OK, res.Code);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was causing a test failure.

ArangoDB behaviour appears to have changed in some release >3.10.0 and the Code property is 0 instead of the expected 200.

@rossmills99 rossmills99 self-assigned this Dec 7, 2023
@rossmills99 rossmills99 changed the title Task/479 Add tests for ArangoDB 3.11. Fix #479 Add tests for ArangoDB 3.11. Dec 8, 2023
@DiscoPYF
Copy link
Collaborator

Since it isn't a documented part of the API, I think just removing the check from the test is an appropriate course of action.

This one is minor but I wouldn't rely on the API documentation being up to date. We found so many instances where properties aren't documented as they should.

@DiscoPYF DiscoPYF merged commit aebfb4e into ArangoDB-Community:master Dec 11, 2023
9 checks passed
@DiscoPYF DiscoPYF linked an issue Dec 11, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run tests against ArangoDB 3.11
2 participants