-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #479 Add tests for ArangoDB 3.11. #486
Fix #479 Add tests for ArangoDB 3.11. #486
Conversation
Interesting... appears to be a broken test which starts breaking with some minor version of 3.10.x (before these changes, the tests ran against 3.10.0 and worked fine. Now I've updated so they run on the most recent patch version, and one of them is failing). Now trying to reproduce locally. |
The documentation doesn't mention a "Code" property in the response. The failing test is checking the "Code" property for a match on HttpStatus.OK. However the value of "Code" property is no longer 200 (OK) but is 0. I expect some change was made and the code is not being set any more in the ArangoDB backend. Since it isn't a documented part of the API, I think just removing the check from the test is an appropriate course of action. |
}); | ||
|
||
Assert.Equal(HttpStatusCode.OK, res.Code); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line was causing a test failure.
ArangoDB behaviour appears to have changed in some release >3.10.0 and the Code
property is 0
instead of the expected 200
.
This one is minor but I wouldn't rely on the API documentation being up to date. We found so many instances where properties aren't documented as they should. |
#479 Adds tests for ArangoDB 3.11