GenProxyProcessor and Lists

[kalgon]

Hi,

I have a problem when I try to generate proxies for entities which have collection members:

@GenProxy(isEmbeddedType = true)
public class Parent {

   @UseProxy(ChildProxy.class)
   private List<Child> children;
}

will generate:

@ProxyFor(Parent.class)
public interface ParentProxy extends ValueProxy {

    ChildProxy getChildren();
}

This is not correct, a List<ChildProxy> should have been used as the return type of getChildren().

[branflake2267]

@christiangoudreau

[branflake2267]

You have a point. That seems strange.

[kalgon]

I could work around this limitation by doing this;

@UseProxyName("java.util.List<ChildProxy>")
private List<Child> children;

[bmoritz]

I had a look through the JavaDoc of the UseProxy, UseProxyNAme and GenProxy annotations. As far as I can see it's nowhere said, that Collection classes are automatically taken into account when generating proxies. But neither it's said, that they are not considered.
So I'd at least suggest to change the JavaDoc accordingly.
On the other hand it shouldn't be too difficult to change the code and let it generate Collections of Proxies if necessary. But I'm not so sure if this is/was the intended behaviour; additionally it would make the generation process more difficult to understand: sometimes some magic is doing the right thing for you, sometimes it doesn't.
What do you think?

[kalgon]

It would be nice if @GenProxy could support all types supported by GWT RequestFactory out-of-the-box (and there aren't that many as you can see at https://developers.google.com/web-toolkit/doc/latest/DevGuideRequestFactory#transportable).

If this can't be automatically detected, maybe something like this would be enough:

public enum AssociationType {
  SINGLE, SET, LIST
}

public @interface UseProxy {
  ...
  AssociationType associationType() default SINGLE;
}

[branflake2267]

Thanks for reporting, I'll look deeper into this.

[bmoritz]

Can we close this issue now, as the PR has been merged?

[olafleur]

It is ! ;-)