Spring GWTP-Dispatch secure action simplify configuration, by providing a default value for cookieName. #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng a default value for cookieName.
|
Don't forget to document this (if it's not already done!) |
|
LGTM |
branflake2267
added a commit
that referenced
this pull request
Aug 13, 2013
Spring GWTP-Dispatch secure action simplify configuration, by providing a default value for cookieName.
|
No documentation is required, it is more of a simplification, if the user forgot to specify the securityCookieName on server side the default name is used. No configuration is needed now to use secure action with Spring. |
branflake2267
added a commit
that referenced
this pull request
Apr 4, 2014
Spring GWTP-Dispatch secure action simplify configuration, by providing a default value for cookieName.
hpehl
pushed a commit
to hpehl/GWTP
that referenced
this pull request
Dec 9, 2014
Spring GWTP-Dispatch secure action simplify configuration, by providing a default value for cookieName. Former-commit-id: e7af56e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offer a default name for securityCookie when there any name defined on Spring scanned properties files.
The default name is JSESSIONID, which is the one used in most cases, otherwise the user need to override that by defining it on his property file, the key of the property is securityCookieName.