Added fireEvent(Event<?>) overload to address issue #668 #669
Conversation
| @@ -225,6 +226,10 @@ public void fireEvent(GwtEvent<?> event) { | |||
| getEventBus().fireEventFromSource(event, this); | |||
There was a problem hiding this comment.
public void fireEvent(GwtEvent<?> event)
seems a bit redundant now.
Is there a web bindery replacement for HasHandlers?
There was a problem hiding this comment.
Unfortunately there seems to be no replacement:
http://www.gwtproject.org/javadoc/latest/com/google/web/bindery/event/shared/package-summary.html
There was a problem hiding this comment.
change:
getEventBus().fireEventFromSource(event, this);
to:
fireEvent((Event<?>) event);
Then any future changes to fire event can be made in the one method.
There was a problem hiding this comment.
OK I did the changes as requested (I did commit --amend to make sure that we don't pollute the commit history). Hope this is fine
|
Thanks for the contribution! LGTM @Chris-V @christiangoudreau ? |
|
Looks good to me! |
|
LGTM. Nevermind, the javadoc is inherited. Thanks for the contribution! |
Added fireEvent(Event<?>) overload to address issue #668
No description provided.