Stop swallowing compile errors ApplicationControllerGenerator! #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a type produces GWT compile errors (i.e. Java compile errors or non-client code errors) the TypeOracle#findType returns null on types that are affected by the compile error. Most of the time this would be the entry point classes, resulting in an ambiguous error message when producing the ApplicationController. For example when it attempts to load the Bootstrapper it returns the type as null when there are Java compile errors or GWT client specific compile errors originating from the entry-point class. For example, this is the error I would expect to see: [WARN] Class com.bugs.NotInClientOrSharedPackage is used in Gin, but not available in GWT client code. But instead I would get something like this: [ERROR] The type 'nz.co.doltech.xxx.client.Application.PreBootstrapImpl' was not found. This issue has bugged be for quite some time now especially when an ammeter with GWT is using GWTP so its nice to finally have it resolved!
| Scheduler.get().scheduleDeferred(new Scheduler.ScheduledCommand() { | ||
| @Override | ||
| public void execute() { | ||
| RootPanel.get().add(new HTML("<h3>" + REASON + "</h3>")); |
There was a problem hiding this comment.
Not sure about this h3.
@jasonlemay Maybe you can suggest / style something? This will display an error instead of the app when something went wrong during the compilation.
There was a problem hiding this comment.
Well its just an error message, the intention is that it will simply warn the user of a problem that needs to be fixed.
|
LGTM. Clever workaround |
|
We can change the message any time anyways. Thanks for the contribution! |
Chris-V
added a commit
that referenced
this pull request
Oct 19, 2015
Stop swallowing compile errors ApplicationControllerGenerator!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a type produces GWT compile errors (i.e. Java compile errors or client code errors) the
TypeOracle#findTypereturns null on types that are affected by the compile error. Most of the time this would be the entry point classes, resulting in an ambiguous error message when producing the ApplicationController. For example when it attempts to load the Bootstrapper it returns the type as null when there are Java compile errors or GWT client specific compile errors originating from the entry-point class.For example, this is the error I would expect to see:
But instead I would get something like this:
This issue has bugged be for quite some time now especially when an ammeter with GWT is using GWTP so its nice to finally have it resolved!
Before:
After: