Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests #2042

Merged
merged 3 commits into from
Mar 5, 2025
Merged

Update tests #2042

merged 3 commits into from
Mar 5, 2025

Conversation

gramian
Copy link
Collaborator

@gramian gramian commented Mar 4, 2025

What does this PR do?

This change deactivates the JdbcQueriesTest named createSchemaWithSqlScript as it triggers a bug. Also leftover elon identites are replaced.

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@lvca lvca requested a review from robfrank March 4, 2025 19:34
@lvca lvca added this to the 25.3.1 milestone Mar 4, 2025
@lvca lvca added the documentation Improvements or additions to documentation label Mar 4, 2025
robfrank
robfrank approved these changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@robfrank robfrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robfrank robfrank merged commit c476e8e into ArcadeData:main Mar 5, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robfrank robfrank robfrank approved these changes

Assignees

@gramian gramian

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
25.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@gramian @robfrank @lvca