chore: fix fqns

[robfrank]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @robfrank, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant code refactoring effort aimed at improving the overall readability and maintainability of the codebase. It systematically replaces Fully Qualified Names (FQNs) with direct class names, accompanied by the addition of corresponding import statements. This change touches various parts of the system, including query engines, parser components, and database utilities, making the code cleaner and easier to understand without introducing any functional modifications.

Highlights

• Code Readability Improvement: Eliminated verbose Fully Qualified Names (FQNs) throughout the codebase, replacing them with simpler class names to enhance readability.
• Import Statement Management: Added necessary import statements to various Java files to support the removal of FQNs, ensuring proper class resolution.
• Scope of Changes: The refactoring impacts core components related to query parsing (SQL and OpenCypher), database record handling (e.g., RID lookups), schema operations, and utility methods across the engine, gremlin, and integration modules.
• Functional Equivalence: These changes are purely stylistic and do not alter the functional behavior or logic of the application.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[mergify]

🧪 CI Insights

Here's what we observed from your CI run for f187606.

🟢 All jobs passed!

But CI Insights is watching 👀

[gemini-code-assist]

Code Review

This pull request focuses on cleaning up the codebase by removing fully qualified class names in favor of imports, which improves readability. The changes are generally good, but I've found a critical issue in one of the test files where a necessary import for GlobalConfiguration was not added after removing its fully qualified name. This will cause a compilation failure and needs to be addressed.

[gemini-code-assist]

The fully qualified name com.arcadedb.GlobalConfiguration was removed, but the corresponding import import com.arcadedb.GlobalConfiguration; is missing. This will cause a compilation error. Please add the import or revert the changes in this file.

Suggested change

	GlobalConfiguration.SQL_PARSER_IMPLEMENTATION.setValue("antlr");
	StatementCache cacheAntlr = new StatementCache(database, 0);
	MatchStatement stmtAntlr = (MatchStatement) cacheAntlr.get(query);
	Map<String, Object> jsonAntlr = stmtAntlr.toJSON();
	printJSON(jsonAntlr, 0);
	System.out.println("\n\n=== JavaCC Parser AST ===");
	com.arcadedb.GlobalConfiguration.SQL_PARSER_IMPLEMENTATION.setValue("javacc");
	GlobalConfiguration.SQL_PARSER_IMPLEMENTATION.setValue("javacc");
	com.arcadedb.GlobalConfiguration.SQL_PARSER_IMPLEMENTATION.setValue("antlr");
	StatementCache cacheAntlr = new StatementCache(database, 0);
	MatchStatement stmtAntlr = (MatchStatement) cacheAntlr.get(query);
	Map<String, Object> jsonAntlr = stmtAntlr.toJSON();
	printJSON(jsonAntlr, 0);
	System.out.println("\n\n=== JavaCC Parser AST ===");
	com.arcadedb.GlobalConfiguration.SQL_PARSER_IMPLEMENTATION.setValue("javacc");

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.09%	✅ 51.72%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (34ef01d)	114154	62321	54.59%
Head commit (f187606)	114154 (+0)	62221 (-100)	54.51% (-0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#3219)	58	30	51.72%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences