Skip to content

TLS improvements#855

Merged
lvca merged 4 commits intoArcadeData:mainfrom
lucian-cm:refactor_tls_logic
Feb 13, 2023
Merged

TLS improvements#855
lvca merged 4 commits intoArcadeData:mainfrom
lucian-cm:refactor_tls_logic

Conversation

@lucian-cm
Copy link
Contributor

@lucian-cm lucian-cm commented Feb 12, 2023

  • Fixed defect with Undertow's TLS truststore and TLS keystore sharing the same password
  • Undertow's TLS default keystore type is read from javax.net.ssl.keyStoreType if valid, otherwise it is PKCS12 (previously it was hardcoded to JKS)
  • Undertow's TLS default truststore type is read from javax.net.ssl.trustStoreType system property if valid, otherwise it is JKS (previously it was hardcoded to JKS)
  • Using latest TLS protocol TLSv1.3 for Undertow's HTTPS listener (previously it was not guaranteed to be TLSv1.3)
  • Refactored some of the TLS handling logic

@lucian-cm
Copy link
Contributor Author

lucian-cm commented Feb 12, 2023

@lvca, this PR is in relation to #775
Please take a look when you can.

@lvca
Copy link
Contributor

lvca commented Feb 12, 2023

Hi @lucian-cm, thanks, for checking it asap. Did you install pre-commit? https://github.com/ArcadeData/arcadedb/blob/main/CONTRIBUTING.md#pre-commit

@lucian-cm
Copy link
Contributor Author

lucian-cm commented Feb 13, 2023

Hi @lucian-cm, thanks, for checking it asap. Did you install pre-commit? https://github.com/ArcadeData/arcadedb/blob/main/CONTRIBUTING.md#pre-commit

Thanks @lvca for your timely reply. I forgot to add the pre-commit checker before. I added it now and did not find anything to fix. It appears that the following tests are failing, which I believe are not related to my changes.

Results:
2023-02-12T21:50:59.8062567Z [INFO]
2023-02-12T21:50:59.8069175Z [ERROR] Failures:
2023-02-12T21:50:59.8077961Z [ERROR] DateTest.testInstant:392 expected: <2023-02-12T21:21:20.963787Z> but was: <2023-02-12T21:21:20.963787900Z>
2023-02-12T21:50:59.8078476Z [ERROR] DateTest.testSQLMath:449 expected: but was:
2023-02-12T21:50:59.8079213Z [ERROR] DateTest.testZonedDateTime:343 expected: but was:
2023-02-12T21:50:59.8079570Z [ERROR] Errors:
2023-02-12T21:50:59.8125883Z [ERROR] UpdateStatementExecutionTest.testLocalDateTimeUpsertWithIndex:892->lambda$testLocalDateTimeUpsertWithIndex$1:894 � DuplicatedKey Duplicated key [2023-02-12T21:48:59.484061, 2023-02-12T21:48:59.484061] found on index 'Product_1_25
80549119200' already assigned to record #9:0

Second test: I saw the problem is the fact that the saved value for date1 is less than the original date1, such that that the test has a wrong expected value to include the saved value of date1
date1 = 2023-02-13T10:33:26.869755500
date2 = 2023-02-13T10:33:27.869755500
result contains just the right side date, that is 2023-02-13T10:33:27.869755

a fix would be
image

@lvca lvca merged commit 030cf6f into ArcadeData:main Feb 13, 2023
@lvca
Copy link
Contributor

lvca commented Feb 13, 2023

Thanks @lucian-cm, merged!

@lvca lvca self-requested a review February 13, 2023 18:17
@lvca lvca added enhancement New feature or request security labels Feb 13, 2023
@lvca lvca added this to the 23.2.1 milestone Feb 13, 2023
@lucian-cm
Copy link
Contributor Author

lucian-cm commented Feb 14, 2023

@lvca, thank you 👍 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants