Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BinaryFile and UnicodeFile sub types #81

Merged
merged 6 commits into from
Sep 16, 2024
Merged

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Sep 16, 2024

  • Renamed DataSerialization to TextSerialization
  • Created BinaryFile and UnicodeFile types in favour of setting class variable binary = True|False
  • Created WithClassifier multiple_classifier = True|False
  • WithOrderedClassifiers instead of ordered_classifiers = True|False

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 97.23320% with 7 lines in your changes missing coverage. Please review.

Project coverage is 92.07%. Comparing base (34a7013) to head (b4dfb25).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
fileformats/generic/file.py 85.00% 1 Missing and 2 partials ⚠️
fileformats/application/serialization.py 90.00% 2 Missing ⚠️
fileformats/field/__init__.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   92.08%   92.07%   -0.02%     
==========================================
  Files          45       45              
  Lines        5233     5226       -7     
  Branches      582      585       +3     
==========================================
- Hits         4819     4812       -7     
+ Misses        310      308       -2     
- Partials      104      106       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tclose tclose merged commit 160e789 into main Sep 16, 2024
17 checks passed
@tclose tclose deleted the binary-file-class branch September 16, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant