fix: allow defaults to be given undefined for supplied

Arcath · Apr 14, 2021 · 3654b58 · 3654b58
1 parent 29ffef1
commit 3654b58
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/functions/defaults.spec.ts b/src/functions/defaults.spec.ts
@@ -46,4 +46,14 @@ describe('Defaults', () => {
     expect(result.colors.red).toBe('#f00')
     expect(result.build).toBe(true)
   })
+
+  it('should allow supplied to be undefined', () => {
+    const defaultOptions = {
+      test: true
+    }
+
+    const results = defaults(undefined, defaultOptions)
+
+    expect(results.test).toBe(true)
+  })
 })
diff --git a/src/functions/defaults.ts b/src/functions/defaults.ts
@@ -11,10 +11,10 @@ export type DeepPartial<T> = {
  * @param supplied The supplied options, a `DeepPartial` of `defaultValues`.
  * @param defaultValues The default values to fallback on. Should represent a full copy of the options object.
  */
-export const defaults = <T extends {}>(supplied: DeepPartial<T>, defaultValues: T) => {
+export const defaults = <T extends {}>(supplied: DeepPartial<T> | undefined, defaultValues: T) => {
   const result: T = {...defaultValues}
 
-  Object.keys(supplied).forEach((key) => {
+  Object.keys(supplied || {}).forEach((key) => {
     if(typeof (defaultValues as {[key: string]: string})[key] === 'object'){
       (result as {[key: string]: string})[key] = defaults(
         //eslint-disable-next-line