Skip to content
This repository has been archived by the owner on Jul 19, 2024. It is now read-only.

No icon on linux in taskbar #38

Closed
1 task done
andrej-urvantsev opened this issue Oct 9, 2023 · 5 comments
Closed
1 task done

No icon on linux in taskbar #38

andrej-urvantsev opened this issue Oct 9, 2023 · 5 comments
Labels

Comments

@andrej-urvantsev
Copy link

Expected Behavior

Some icon would be nice to have.

Actual Behavior

image

Reproduction Steps

  1. Install 0.2.1-b

Is there an existing issue for this?

Additional Information

No response

Insomnium Version

0.2.1-b

What operating system are you using?

Ubuntu

Operating System Version

KDE Neon 5.2.7

Installation method

deb

Last Known Working Insomnium version

0.1.3

@andrej-urvantsev
Copy link
Author

Actually, now I think that application icons didn't work correctly even in 0.1.3

In 0.1.3 I see default InsomniA icon, which I guess packed in Electron, but icon in the deb package is different.

@andrej-urvantsev
Copy link
Author

Ok, I think it's related to electron-userland/electron-builder#5294

Inside the deb package icon is indeed in the 0x0 folder.

So I guess solution would be to provide pre-scaled icons, according to https://www.electron.build/icons.html#linux

@archywillhe
Copy link
Member

Ok, I think it's related to electron-userland/electron-builder#5294

aw thanks! good find; I will resolve this in the next release

@andrej-urvantsev
Copy link
Author

andrej-urvantsev commented Oct 25, 2023

@archywillhe it's almost fixed, one more line is needed: icon: 'src/icons'

In electron-builder.config.js:

  linux: {
    artifactName: `${BINARY_PREFIX}-\${version}.\${ext}`,
    executableName: 'insomnia',
    icon: 'src/icons',

Tried it locally - can see icon in the taskbar now:

image

archywillhe added a commit that referenced this issue Oct 26, 2023
#38 Use pre-scaled icons for linux build
@archywillhe
Copy link
Member

thanks! meriging your pr now :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants