Zillion: map tracker in client #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and some debug statements for asserts, documentation on running scripts for manual testing type correction in CommonContext
…resses in slot data
fix item locations getting out of sync in progression balancing
instead of all the multiworld locations
and some unit tests
and add memory read timeout
Opa-Opa is a proper noun
but it breaks other parts of the UI
and some type checking details
|
The direct hardcoded path did NOT work with the windows executable builds, as the path in that instance ends up being "lib/worlds/zillion/empty-zillion-map-row-col-labels-281.png" instead of just "worlds/zillion/empty-zillion-map-row-col-labels-281.png". |
CaitSith2
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
adds a map tracker to the Zillion client
As part of this, kivy loads an image from
worlds/zillion/. I don't know if that will work when this is in the Windows executables.This also adds some kivy type stubs. They are incomplete and probably have mistakes, but it's better than not having any types for kivy.
How was this tested?
a few self-async games
I'm going to try to get a beta test with some other players together.
Also opened up other python clients to make sure they weren't obviously messed up.
If this makes graphical changes, please attach screenshots.