Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rogue Legacy: Fix early vendors and architect not being added to pool. #1314

Merged
merged 1 commit into from
Dec 10, 2022

Conversation

ThePhar
Copy link
Member

@ThePhar ThePhar commented Dec 10, 2022

What is this fixing or adding?

Early vendors and Early architect do the exact opposite of what I wanted. They don't get added to pool. Wups.

How was this tested?

Generated. They are back.

If this makes graphical changes, please attach screenshots.

@Berserker66
Copy link
Member

Berserker66 commented Dec 10, 2022

should maybe the get_setting if be moved out of the item table loop?
should allow skipping to check for if name == "Blacksmith" or name == "Enchantress": on every iteration
edit: nevermind, special handling of start_unlocked would still need it :/

@ThePhar ThePhar merged commit ce42fda into ArchipelagoMW:main Dec 10, 2022
LiquidCat64 pushed a commit to LiquidCat64/LiquidCatipelago that referenced this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants