Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zillion: Python 3.11 compatibility fix #2105

Merged

Conversation

beauxq
Copy link
Collaborator

@beauxq beauxq commented Aug 14, 2023

What is this fixing or adding?

https://docs.python.org/3/library/asyncio-task.html

Changed in version 3.11: Passing coroutine objects to wait() directly is forbidden.

How was this tested?

in Python 3.11
connected to MultiServer with a game and checked a location
(what didn't work before this change)

edit: now I've finished a full multiworld game with these changes

@beauxq beauxq changed the title [Zillion] 3.11 compatibility fix [Zillion] Python 3.11 compatibility fix Aug 14, 2023
ZillionClient.py Show resolved Hide resolved
@ThePhar ThePhar changed the title [Zillion] Python 3.11 compatibility fix Zillion: Python 3.11 compatibility fix Aug 16, 2023
@ThePhar ThePhar added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. affects: release/blocker Issues/PRs that must be addressed before next official release. labels Aug 16, 2023
@ThePhar ThePhar merged commit 26b4ff1 into ArchipelagoMW:main Aug 16, 2023
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: release/blocker Issues/PRs that must be addressed before next official release. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants