Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stardew Valley: Added rules requiring museum access to make donations #2107

Merged

Conversation

agilbert1412
Copy link
Collaborator

What is this fixing or adding?

When using Museumsanity with Entrance Randomizer, it is possible that the museum is not immediately accessible.
This adds logic rules that were previously missing, requiring museum access before you can make any donation

How was this tested?

  • Created new unit tests for the desired behavior, checked that they failed, applied the fixes, checked that they now succeed
  • Ran all previous tests as well

@ThePhar ThePhar changed the title Stardew Valley - Added rules requiring museum access to make donations Stardew Valley: Added rules requiring museum access to make donations Aug 16, 2023
@ThePhar ThePhar added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Aug 16, 2023
@ThePhar ThePhar merged commit 7ce9f20 into ArchipelagoMW:main Aug 16, 2023
@agilbert1412 agilbert1412 deleted the StardewValley/MuseumEntranceLogic branch December 6, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants