ALTTP: Rename Map/Compass/Big Key Chests and similar to something more informative #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dungeon chests named for their vanilla contents have been renamed to describe their locations instead.
The Location Groups for ALTTP have now been updated to include Key Drop locations.
github-actions
bot
added
the
waiting-on: peer-review
One location where Key Drops were listed had not been updated in the refactoring. This corrects that.
You should follow this guide to get set up with running from source, and do some testing yourself before opening to peer review: |
PoryGone
added
waiting-on: author
Aliases were added, in the form of location groups, with the intent of allowing the renamed locations to be referenced in plando and hints by their old names. But testing shows that these aliases do not work for either one, at least not as intended. So they are being removed.
|
I have now run several tests, with various player settings: Standard/Open/Inverted world state, Key Drop Shuffle on or off, Entrance Shuffle, etc. Everything seems to behave as it should. |
Some new rules have been added since this PR first opened, using the old chest names. This push refactors those to the new names as well.
Exempt-Medic
added
the
is: refactor/cleanup
|
What is this currently waiting on? And how does one change the labels? |
I would assume these conflicts. Also only triage collaborators (or core maintainers) can change labels. |
ThePhar
added
waiting-on: peer-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
A number of locations in ALTTP have names that are unhelpful in determining where to go within their respective dungeons in order to find those checks. The Big Key Chests in particular often get confused with the Big Chests, causing unnecessary difficulty to new players. This PR renames the Map, Compass, and Big Key Chests, along with a small number of other chests that were named for their vanilla contents, giving them names that better describe where in their respective dungeons they appear.
How was this tested?
I do not know how to run from source, and as such, have not been able to test this. I would recommend generating a few games of ALTTP with various settings (Entrance Shuffle, Inverted) and checking to make sure nothing explodes on any of them. I would also suggest digging into the spoiler logs for such generations to ensure the new chest names, not the old ones, appear there.