Hollow Knight: Adding Godhome Goal Logic #2952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
ScipioWright
added
waiting-on: world-maintainer
|
Please re-title to "Hollow Knight: Adding Godhome Goal Logic" |
qwint
changed the title
BadMagic100
suggested changes
Mar 15, 2024
worlds/hk/GodhomeData.py
Outdated
| '*Boss_Geo-Massive_Moss_Charger/': lambda state: state.count('Fungus1_29[left1]', player) or state.count('Fungus1_29[right1]', player), | ||
| 'Bench-Godhome_Atrium/': lambda state: state.count('Bench-Godhome_Atrium', player), | ||
| 'Bench-Hall_of_Gods/': lambda state: state.count('Bench-Hall_of_Gods', player), | ||
| 'Room_Colosseum_01[left1]/': lambda state: state.count('Room_Colosseum_01[left1]', player), |
There was a problem hiding this comment.
Please remove these and reference the underlying event directly, in rando4 logic the postfix / means "discard any state from this term" so it is not meaningful here
There was a problem hiding this comment.
is the * prefix also irrelevant?
There was a problem hiding this comment.
went ahead and assumed it was, and just expanded the logic per a different comment
There was a problem hiding this comment.
Prefix * essentially means "treat the referenced logic definition as a macro"
…ames and comments of unused events
BadMagic100
approved these changes
Mar 15, 2024
BadMagic100
removed
the
waiting-on: world-maintainer
agilbert1412
suggested changes
Mar 15, 2024
agilbert1412
suggested changes
Mar 15, 2024
agilbert1412
approved these changes
Mar 16, 2024
BadMagic100
approved these changes
Mar 16, 2024
BadMagic100
added
waiting-on: core-review
Berserker66
approved these changes
Apr 9, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
qwint
added a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds all the required Event items and logic ported from Rando4 and Journal Rando when appropriate and transformed to fit AP's formatting.
The only rule that was written mostly by hand is "Godhome_Flower_Quest", which is a mix of Flower quest logic from Rando4 with additions of access to the 3 relevant rooms.
I didn't want to change the Generated Data at all, so I created my own source logic file similar to GeneratedRules.py and added extra functions to item/location creation, to create the Godhome events if relevant for the chosen Goal.
Also there was some simplification done to the rules to not need an exhaustive list of helper Events, all conversion should be represented in the logic but commented out. I mostly stopped where I did to reduce chance of human error, but it could be simplified more if desired.
Note: did not (yet?) remove the need for LogicMixin, this only adds the Godhome goals and their logic.
How was this tested?
rolling a few seeds in Siblings (to confirm i didn't break anything), Godhome, and Godhome+Flower Goal options and visually inspected the spoiler log for the correct Events represented in the Playthrough
I will not be playing these seeds.
If this makes graphical changes, please attach screenshots.