Pokemon Emerald: Convert to procedure patch #2995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
|
Moved to draft waiting on #2996 Not dependent on it except to avoid the bug it fixes. |
|
Double-checked the output of a 2-player game now that #2996 is merged, files are identical. |
Zunawe
added
the
is: enhancement
silasary
approved these changes
Mar 27, 2024
CoreZer0
approved these changes
Apr 22, 2024
NewSoupVi
added
waiting-on: core-review
NewSoupVi
approved these changes
May 4, 2024
There was a problem hiding this comment.
I don't 100% understand rom stuff, but I checked the conversion and it seems to be 1:1, so in my estimation anything that that doesn't work here is a problem with APProcedurePatch itself, in which case I think it'd be good to have a big game in that uses it so we can expose any issues with it :) And the "it's been used by the community for a while as an .apworld" and "I compared rom hashes across 9 fully random multiworld seeds" is quite convincing :D
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
* Pokemon Emerald: Convert to procedure patch * Pokemon Emerald: Remove assertion for vanilla rom's existence * Pokemon Emerald: Add APPP implication to changelog * Pokemon Emerald: Move procedure patch changelog line to new version * Pokemon Emerald: Modify changelog versions * Pokemon Emerald: Fix patch file download not appearing --------- Co-authored-by: NewSoupVi <57900059+NewSoupVi@users.noreply.github.com>
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
* Pokemon Emerald: Convert to procedure patch * Pokemon Emerald: Remove assertion for vanilla rom's existence * Pokemon Emerald: Add APPP implication to changelog * Pokemon Emerald: Move procedure patch changelog line to new version * Pokemon Emerald: Modify changelog versions * Pokemon Emerald: Fix patch file download not appearing --------- Co-authored-by: NewSoupVi <57900059+NewSoupVi@users.noreply.github.com>
AustinSumigray
pushed a commit
to AustinSumigray/Archipelago
that referenced
this pull request
Jan 4, 2025
* Pokemon Emerald: Convert to procedure patch * Pokemon Emerald: Remove assertion for vanilla rom's existence * Pokemon Emerald: Add APPP implication to changelog * Pokemon Emerald: Move procedure patch changelog line to new version * Pokemon Emerald: Modify changelog versions * Pokemon Emerald: Fix patch file download not appearing --------- Co-authored-by: NewSoupVi <57900059+NewSoupVi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Converts Emerald to use APProcedurePatch.
extracted_data.jsonwas changed to include a battle type enum. Previously it was being read during patching, but now it's being read whenextracted_data.jsonis created. That's its only change.I know stuff like
struct.pack("<B", 0)is sorta silly, but I like how explicit and consistent it is.How was this tested?
Generated 9 seeds using a fully randomized yaml on
mainand on this branch and compared the md5 hashes of the patched ROM.Community has had access to an apworld that includes this change for a couple weeks and have not reported any issues except #3161, which already existed and was only revealed by these changes.