TUNIC: Better seed groups for Entrance Rando #2998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
ScipioWright
added
is: enhancement
ScipioWright
removed
waiting-on: author
silent-destroyer
approved these changes
Mar 24, 2024
|
Did a few test gens with different ER settings combinations and everything seemed to work fine |
NewSoupVi
approved these changes
Mar 29, 2024
|
Drafting until I can test it all out, don't need a repeat of what happened before |
|
An issue was found, coverting to draft while fixing it |
KScl
suggested changes
Apr 19, 2024
Co-authored-by: Kaito Sinclaire <ks@rosenthalcastle.org>
KScl
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
After the latest fix, everything I've thrown at it to test appears to behave correctly:
- Generates fine with multiple distinct seed groups in the same multiworld, and doesn't change anything for players also in that multiworld who just have ER on normally
- More restrictive ER rules propagate to other players in the same seed group
plando_connectionsrules propagate to other players in the same seed group, and combine correctly if multiple players have them- Conflicting
plando_connectionsrules between multiple players correctly errors out
ScipioWright
added
waiting-on: core-review
NewSoupVi
approved these changes
May 3, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
* Update entrance rando description to discuss seed groups * Starting off, setting up some names * It lives * Some preliminary plando connection handling, probably has errors * Add missed comma * if -> elif * I think this is working properly to handle plando connections * Update comments * Fix up shop -> shop portal stuff * Add back comma that got removed for no reason in the ladder PR * Remove unnecessary if else * add back the actually necessary if but not the else * okay they were both necessary * Update entrance rando description * blasphemy Co-authored-by: Silent <110704408+silent-destroyer@users.noreply.github.com> * Rename other instances of tunc -> tunic * Update per Vi's review (thank you) * Fix a not that shouldn't have been * Rearrange, update per Vi's comments (thank you) * Fix indent * Add a .value * Add .values * Fix bad comparison * Add a not that was supposed to be there * Replace another isinstance * Revise option description * Fix per Kaito's comment Co-authored-by: Kaito Sinclaire <ks@rosenthalcastle.org> --------- Co-authored-by: Silent <110704408+silent-destroyer@users.noreply.github.com> Co-authored-by: Kaito Sinclaire <ks@rosenthalcastle.org>
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
* Update entrance rando description to discuss seed groups * Starting off, setting up some names * It lives * Some preliminary plando connection handling, probably has errors * Add missed comma * if -> elif * I think this is working properly to handle plando connections * Update comments * Fix up shop -> shop portal stuff * Add back comma that got removed for no reason in the ladder PR * Remove unnecessary if else * add back the actually necessary if but not the else * okay they were both necessary * Update entrance rando description * blasphemy Co-authored-by: Silent <110704408+silent-destroyer@users.noreply.github.com> * Rename other instances of tunc -> tunic * Update per Vi's review (thank you) * Fix a not that shouldn't have been * Rearrange, update per Vi's comments (thank you) * Fix indent * Add a .value * Add .values * Fix bad comparison * Add a not that was supposed to be there * Replace another isinstance * Revise option description * Fix per Kaito's comment Co-authored-by: Kaito Sinclaire <ks@rosenthalcastle.org> --------- Co-authored-by: Silent <110704408+silent-destroyer@users.noreply.github.com> Co-authored-by: Kaito Sinclaire <ks@rosenthalcastle.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Makes it so that people who choose the same seed for entrance rando will have the same entrances, even if the settings that alter how entrances are placed (Laurels Location, Logic Rules, and Fewer Shops) are different. It takes the most restrictive of the settings for those in the group.
How was this tested?
Test generations with multiple players, with the above-stated options set to random, and entrance_rando set to a string.
And additional tests with multiple different entrance_rando seed groups, some set to 'true', some with it off, etc.
If this makes graphical changes, please attach screenshots.
N/A