Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV64: Change all mentions of "settings" to "options" and fix a broken link #3015

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions worlds/cv64/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ class CV64Web(WebWorld):

class CV64World(World):
"""
Castlevania for the Nintendo 64 is the first 3D game in the franchise. As either whip-wielding Belmont descendant
Reinhardt Schneider or powerful sorceress Carrie Fernandez, brave many terrifying traps and foes as you make your
way to Dracula's chamber and stop his rule of terror!
Castlevania for the Nintendo 64 is the first 3D game in the Castlevania franchise. As either whip-wielding Belmont
descendant Reinhardt Schneider or powerful sorceress Carrie Fernandez, brave many terrifying traps and foes as you
make your way to Dracula's chamber and stop his rule of terror!
"""
game = "Castlevania 64"
item_name_groups = {
Expand Down
6 changes: 3 additions & 3 deletions worlds/cv64/docs/en_Castlevania 64.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Castlevania 64

## Where is the settings page?
## Where is the options page?

The [player settings page for this game](../player-settings) contains all the options you need to configure and export a
The [player options page for this game](../player-options) contains all the options you need to configure and export a
config file.

## What does randomization do to this game?
Expand Down Expand Up @@ -116,7 +116,7 @@ Enabling Carrie Logic will also expect the following:

- Orb-sniping dogs through the front gates in Villa

Library Skip is **NOT** logically expected on any setting. The basement hallway crack will always logically expect two Nitros
Library Skip is **NOT** logically expected with any option. The basement arena crack will always logically expect two Nitros
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "with any option" here and in options.py are tripping me up a bit. I feel like "by any options" and "under any options" are both a bit better. Alternatively, you could just say "X is/are NEVER considered in logic"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it to your first suggestion.

and two Mandragoras even with Hard Logic on due to the possibility of wasting a pair on the upper wall, after managing
to skip past it. And plus, the RNG manip may not even be possible after picking up all the items in the Nitro room.

Expand Down
4 changes: 2 additions & 2 deletions worlds/cv64/docs/setup_en.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ the White Jewels.

## Generating and Patching a Game

1. Create your settings file (YAML). You can make one on the
[Castlevania 64 settings page](../../../games/Castlevania 64/player-settings).
1. Create your options file (YAML). You can make one on the
[Castlevania 64 options page](../../../games/Castlevania%2064/player-options).
2. Follow the general Archipelago instructions for [generating a game](../../Archipelago/setup/en#generating-a-game).
This will generate an output file for you. Your patch file will have the `.apcv64` file extension.
3. Open `ArchipelagoLauncher.exe`
Expand Down
4 changes: 2 additions & 2 deletions worlds/cv64/options.py
Original file line number Diff line number Diff line change
Expand Up @@ -337,13 +337,13 @@ class BigToss(Toggle):
"""Makes every non-immobilizing damage source launch you as if you got hit by Behemoth's charge.
Press A while tossed to cancel the launch momentum and avoid being thrown off ledges.
Hold Z to have all incoming damage be treated as it normally would.
Any tricks that might be possible with it are NOT considered in logic on any setting."""
Any tricks that might be possible with it are NOT considered in logic with any option."""
display_name = "Big Toss"


class PantherDash(Choice):
"""Hold C-right at any time to sprint way faster. Any tricks that might be
possible with it are NOT considered in logic on any setting and any boss
possible with it are NOT considered in logic with any option and any boss
fights with boss health meters, if started, are expected to be finished
before leaving their arenas if Dracula's Condition is bosses. Jumpless will
prevent jumping while moving at the increased speed to ensure logic cannot be broken with it."""
Expand Down
Loading