Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Player name property on world class #3042

Merged
merged 3 commits into from
May 17, 2024
Merged

Core: Player name property on world class #3042

merged 3 commits into from
May 17, 2024

Conversation

NewSoupVi
Copy link
Member

@NewSoupVi NewSoupVi commented Mar 27, 2024 •
edited
Loading

self.multiworld.get_player_name(self.player) is so stupid lol

Edit: Overcooked was already doing this itself so I needed to make it not do that. @toasterparty

@NewSoupVi NewSoupVi added the is: enhancement Issues requesting new features or pull requests implementing new features. label Mar 27, 2024
@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Mar 27, 2024
@NewSoupVi
Copy link
Member Author

Oh god damnit

@NewSoupVi NewSoupVi force-pushed the playername_convenience branch from 70d74bb to 109754f Compare March 27, 2024 19:23
@NewSoupVi NewSoupVi requested a review from toasterparty March 27, 2024 19:23
@NewSoupVi NewSoupVi added the waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. label Mar 28, 2024
beauxq
beauxq reviewed Mar 28, 2024
View reviewed changes
worlds/AutoWorld.py Outdated Show resolved Hide resolved
@NewSoupVi @beauxq
Update worlds/AutoWorld.py
52945c9 
Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com>
@NewSoupVi NewSoupVi changed the title Core: Player property on world class Core: Player name property on world class Apr 5, 2024
@NewSoupVi NewSoupVi removed the waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. label May 8, 2024
hatkirby
hatkirby approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@hatkirby hatkirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and self explanatory. Lgtm.

@NewSoupVi NewSoupVi added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels May 8, 2024
ScipioWright
ScipioWright approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very simple

Exempt-Medic
Exempt-Medic approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and it works

black-sliver
black-sliver approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by world devs and I see no reason against adding it.

@NewSoupVi NewSoupVi merged commit 5fb0126 into ArchipelagoMW:main May 17, 2024
15 checks passed
This was referenced Jun 7, 2024
Merged
Open
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
@NewSoupVi @beauxq
Core: Player name property on world class (ArchipelagoMW#3042)
0a9f578 
* player property on world class

* Remove dat shi from overcooked

* Update worlds/AutoWorld.py

Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com>

---------

Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com>
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@NewSoupVi @beauxq @qwint
Core: Player name property on world class (ArchipelagoMW#3042)
3034ae3 
* player property on world class

* Remove dat shi from overcooked

* Update worlds/AutoWorld.py

Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com>

---------

Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beauxq beauxq beauxq left review comments

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@black-sliver black-sliver black-sliver approved these changes

@ScipioWright ScipioWright ScipioWright approved these changes

@toasterparty toasterparty toasterparty approved these changes

@hatkirby hatkirby hatkirby approved these changes

Assignees
No one assigned
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@NewSoupVi @hatkirby @beauxq @toasterparty @ScipioWright @black-sliver @Exempt-Medic