Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC2 Documentation: Fix the page titles #3074

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

Ziktofel
Copy link
Collaborator

@Ziktofel Ziktofel commented Apr 1, 2024

What is this fixing or adding?

Fix documentation title

How was this tested?

Documentation-only

If this makes graphical changes, please attach screenshots.

nothing important, just text changes

@Ziktofel Ziktofel added the is: documentation Improvements or additions to documentation. label Apr 1, 2024
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 1, 2024
@neocerber
Copy link
Contributor

PR #3031 also proposes these modifications. However, it is true that it is technically outside of its scope XD

Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 5, 2024
Copy link
Contributor

@MatthewMarinets MatthewMarinets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid, would slightly reduce the scope of #3031

Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seconding on reducing scope on other PR

@Berserker66 Berserker66 merged commit 5da3a40 into ArchipelagoMW:main Apr 16, 2024
10 checks passed
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants