Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SA2B: Update Setup guide for new Mod Manager #3085

Merged
merged 4 commits into from
Apr 18, 2024
Merged

SA2B: Update Setup guide for new Mod Manager #3085

merged 4 commits into from
Apr 18, 2024

Conversation

PoryGone
Copy link
Collaborator

@PoryGone PoryGone commented Apr 3, 2024

What is this fixing or adding?

SA2 now has a fancy new Mod Manager, and the old one is deprecated. This requires slightly different setup instructions.

Additionally, a single, much-requested option tooltip clarification is included.

How was this tested?

We read it, and followed it, and it worked.

If this makes graphical changes, please attach screenshots.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 3, 2024
@PoryGone PoryGone added the is: documentation Improvements or additions to documentation. label Apr 3, 2024
nicholassaylor
nicholassaylor approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through the updated guide and checked all links. Guide was easy to follow
Did not install SA2B or the mod manager as part of reading
LGTM

Exempt-Medic
Exempt-Medic reviewed Apr 5, 2024
View reviewed changes
worlds/sa2b/Options.py Outdated Show resolved Hide resolved
Exempt-Medic
Exempt-Medic approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on the option wording, but otherwise everything else LGTM

@Exempt-Medic Exempt-Medic added waiting-on: author Issue/PR is waiting for feedback or changes from its author. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 5, 2024
@PoryGone PoryGone added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: author Issue/PR is waiting for feedback or changes from its author. labels Apr 6, 2024
@ScipioWright ScipioWright added the affects: release/blocker Issues/PRs that must be addressed before next official release. label Apr 14, 2024
@Berserker66 Berserker66 merged commit c4c4069 into ArchipelagoMW:main Apr 18, 2024
15 checks passed
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@PoryGone @qwint
SA2B: Update Setup guide for new Mod Manager (ArchipelagoMW#3085)
9be9844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@RaspberrySpace RaspberrySpace RaspberrySpace left review comments

@nicholassaylor nicholassaylor nicholassaylor approved these changes

@Berserker66 Berserker66 Berserker66 approved these changes

Assignees
No one assigned
Labels
affects: release/blocker Issues/PRs that must be addressed before next official release. is: documentation Improvements or additions to documentation. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PoryGone @Berserker66 @RaspberrySpace @Exempt-Medic @nicholassaylor @ScipioWright