Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: disable automatic yaml line breaks #3096

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Settings: disable automatic yaml line breaks #3096

merged 4 commits into from
Apr 18, 2024

Conversation

black-sliver
Copy link
Member

@black-sliver black-sliver commented Apr 4, 2024 •
edited
Loading

What is this fixing or adding?

settings.py could hit an assert from automatic yaml line breaks. This disables them (and leaves the assert in).
Also fixes typing in the existing host.yaml tests.

How was this tested?

@github-actions github-actions bot added the affects: core Issues/PRs that touch core and may need additional validation. label Apr 4, 2024
@black-sliver black-sliver added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Apr 4, 2024
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 4, 2024
@black-sliver black-sliver force-pushed the settings-disable-automatic-line-breaks branch 2 times, most recently from 5f6f142 to 723bb45 Compare April 5, 2024 08:28
@black-sliver black-sliver force-pushed the settings-disable-automatic-line-breaks branch from 433ec29 to 5319ddb Compare April 5, 2024 16:54
@black-sliver black-sliver merged commit 6087ec5 into ArchipelagoMW:main Apr 18, 2024
15 checks passed
@black-sliver black-sliver deleted the settings-disable-automatic-line-breaks branch April 18, 2024 17:13
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@black-sliver @qwint
Settings: disable automatic yaml line breaks (ArchipelagoMW#3096)
690c92d 
* Settings: disable automatic yaml line breaks

* Tests: add settings formatting checks

* Tests: fix typing in test_host_yaml
@black-sliver black-sliver mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Berserker66 Berserker66 Berserker66 approved these changes

Assignees
No one assigned
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@black-sliver @Berserker66