-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yoshi's Island: Fix Outdated Connection Setup #3113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
is: documentation
Improvements or additions to documentation.
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
labels
Apr 7, 2024
PinkSwitch
changed the title
Fix outdated doc
Yoshi's Island: Fix Outdated Connection Setup
Apr 7, 2024
ScipioWright
approved these changes
Apr 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, file path is correct
ScipioWright
added
waiting-on: core-review
Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
and removed
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
labels
Apr 7, 2024
nicholassaylor
approved these changes
Apr 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Berserker66
approved these changes
Apr 14, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
is: documentation
Improvements or additions to documentation.
waiting-on: core-review
Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please format your title with what portion of the project this pull request is
targeting and what it's changing.
ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"
What is this fixing or adding?
SNES9x-rr portion of setup_en referenced outdated connection information, this updates it.
How was this tested?
I ran the webhost with the change made to confirm that the change works.
If this makes graphical changes, please attach screenshots.
Before:
After: