Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zillion: Docs: add information to skill option documentation #3118

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

beauxq
Copy link
Collaborator

@beauxq beauxq commented Apr 8, 2024

What is this fixing or adding?

This is a common question that comes up in the Zillion discord channel.

"What does the skill option do?"

How was this tested?

run WebHost.py, open zillion options page to see how it looks there

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 8, 2024
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine on webhost. Something that should probably happen eventually is making the formatting consistent for the options, but that's out of scope for this PR

@Exempt-Medic Exempt-Medic added the is: refactor/cleanup Improvements to code/output readability or organizization. label Apr 8, 2024
@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. is: documentation Improvements or additions to documentation. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. is: refactor/cleanup Improvements to code/output readability or organizization. labels Apr 19, 2024
@ThePhar ThePhar merged commit fc18f9c into ArchipelagoMW:main Apr 21, 2024
15 checks passed
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants