Zork Grand Inquisitor: Fix Determinism Issues on Fixed Seeds #3134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out I had 2 separate small issues affecting determinism on fixed seeds:
get_filler_item_names
In both cases, I made sure the operations happened on lists instead to make sure the order is deterministic.
Before
2 generations with fixed seed
12345
would yield completely different item placement, progression items includedAfter
2 generations with fixed seed
12345
yield identical item placementWorld tests are still green after the changes.