Noita: Add more location groups, capitalize existing ones #3141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
ScipioWright
added
the
is: enhancement
ScipioWright
added
waiting-on: core-review
|
ltype isn't referenced elsewhere correct? Otherwise looks fine I guess. |
heinermann
approved these changes
Apr 18, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
…oMW#3141) * Add location groups for each region * Capitalize existing location groups * Capitalize new boss location group names * Update comment with capitalization * Capitalize location_type in reigons.py
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
…oMW#3141) * Add location groups for each region * Capitalize existing location groups * Capitalize new boss location group names * Update comment with capitalization * Capitalize location_type in reigons.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds location groups for each of the biomes to the game, to make it easier to exclude biomes that the player does not like. Also capitalizes the existing location groups since that looks like it's more standard.
How was this tested?
Generating, doing /location_groups or whatever the command is in text client, hinting some of them
If this makes graphical changes, please attach screenshots.
N/A