Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LttP: remove glitch triforce setting #3174

Merged
merged 1 commit into from
Apr 19, 2024
Merged

LttP: remove glitch triforce setting #3174

merged 1 commit into from
Apr 19, 2024

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

remove glitch triforce setting

How was this tested?

nope

If this makes graphical changes, please attach screenshots.

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 18, 2024
@ThePhar ThePhar added is: refactor/cleanup Improvements to code/output readability or organizization. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. labels Apr 19, 2024
ThePhar
ThePhar approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@ThePhar ThePhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason it still worked on Generate.py before this change, but WebHost didn't like it.

Did confirm it would generate however on WebHost with this change.

@Berserker66 Berserker66 merged commit 7a004de into main Apr 19, 2024
26 checks passed
@Berserker66 Berserker66 deleted the lttp_glitch_triforce branch April 19, 2024 21:10
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@Berserker66 @qwint
LttP: remove glitch triforce setting (ArchipelagoMW#3174)
172502f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThePhar ThePhar ThePhar approved these changes

Assignees
No one assigned
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Berserker66 @ThePhar