Pokemon Emerald: Add event ticket locations to client data store flags #3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Zunawe
added
the
is: enhancement
|
Added an event flag for the |
Exempt-Medic
approved these changes
Apr 22, 2024
Exempt-Medic
added
waiting-on: core-review
|
I added |
|
Added a few more flags at the request of the tracker devs |
Zunawe
force-pushed
the
emerald-event-ticket-flags
branch
from
5b32c6e to
d48ac26
Compare
|
Tracker dev here, I have verified that that these changes worked for autotracking the new events and key items |
Exempt-Medic
added
waiting-on: core-review
NewSoupVi
approved these changes
May 5, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
ArchipelagoMW#3177) * Pokemon Emerald: Add event ticket locations to client data store flags * Pokemon Emerald: Add regi doors event flag * Pokemon Emerald: Add more tracker flags
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
ArchipelagoMW#3177) * Pokemon Emerald: Add event ticket locations to client data store flags * Pokemon Emerald: Add regi doors event flag * Pokemon Emerald: Add more tracker flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds the event ticket locations to the
pokemon_emerald_keys_data storage key so that they can be autotracked even if they're not randomized.This pushes the key over 32 bits, but that's probably not an issue for anyone.
How was this tested?
It wasn't except to run the launcher, which should verify that these keys have location data. I'll hand this PR over to the tracker devs to verify.