Factorio: Fix 500 error on Factorio multi-tracker. #3184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: webhost
ThePhar
added
the
is: bug/fix
LegendaryLinux
approved these changes
Apr 20, 2024
beauxq
reviewed
Apr 20, 2024
| @@ -422,11 +422,11 @@ def render_generic_multiworld_tracker(tracker_data: TrackerData, enabled_tracker | |||
|
|
|||
| if "Factorio" in network_data_package["games"]: | |||
| def render_Factorio_multiworld_tracker(tracker_data: TrackerData, enabled_trackers: List[str]): | |||
| inventories: Dict[TeamPlayer, Dict[int, int]] = { | |||
| (team, player): { | |||
| inventories: Dict[TeamPlayer, collections.Counter[str]] = { | |||
There was a problem hiding this comment.
This collections.Counter[str] type annotation won't work in Python 3.8.
Suggested change
| inventories: Dict[TeamPlayer, collections.Counter[str]] = { | |
| inventories: Dict[TeamPlayer, Counter[str]] = { |
Another workaround to fix it without typing.Counter is just to put the whole type annotation in quotes.
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
* Factorio: Fix 500 error on Factorio multi-tracker. * Hopefully this also fixes the webhost test failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Makes a dict into a Counter collection to prevent a "attr not found" error.
Also fixes a type hint that was wrong.
How was this tested?
Ran webhost and checked tracker.
If this makes graphical changes, please attach screenshots.
N/A