SNIClient: set SNESState to SNES_DISCONNECTED when disconnected #3188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Zunawe
added
the
is: bug/fix
Berserker66
approved these changes
Apr 21, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
When we disconnect from the SNES (intentional or otherwise), we don't actually change our state to reflect this. This means SNIClient cannot reconnect, as
snes_connectwill see our status as SNES_CONNECTED and think we're waiting on the SNES to load a game.How was this tested?
Connected to Snes9x-rr using SNI's lua, and then paused the emulator, forcing SNIClient to disconnect. Then, unpaused the emulator and confirmed that SNIClient was capable of reconnecting without any further help.