Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aquaria: implement new game #3197

Merged
merged 68 commits into from
May 17, 2024
Merged

Aquaria: implement new game #3197

merged 68 commits into from
May 17, 2024

Conversation

tioui
Copy link
Collaborator

@tioui tioui commented Apr 22, 2024

Aquaria: implement new game

What is this fixing or adding?

This is a new world for the Aquaria game (https://www.bit-blot.com/aquaria/).

How was this tested?

I have personally played the randomizer with all options a couple of times (single world only). There are also two other players that have played multiple run of the game (including multi-world game) and other than some minor logic problems (nothing game breaking), the world and the client appear to be quite solid.

Also, I have created some unit tests to valid important progression logic.

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 29, 2024
Copy link
Contributor

@neocerber neocerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at the setup and game pages, in French and English. I have never played the game. French is my first language.

General comments:

  • The terms randomiser, "randomizer" and randomizer are used in the French part. One of the first two should be chosen.
  • The bash command use the wild card *. If multiples versions of the executable/appimage are available, this might cause a problem. You might want to warn the user about that.
  • The link to fr_Aquaria is not available directly on the website. (The page is generated, but not explicitly linked) I suggest doing as Docs, Starcraft 2: Add French documentation for setup and game page #3031, but this is not officially sanctioned.

Except for the general and specifics comments, the text of both the setup and game pages (French and English) seems good. I also confirm that the French part corresponds to its English counterpart. I have hosted locally the website and confirms that the links work as intended.

worlds/aquaria/docs/setup_fr.md Outdated Show resolved Hide resolved
worlds/aquaria/docs/fr_Aquaria.md Outdated Show resolved Hide resolved
worlds/aquaria/docs/setup_fr.md Outdated Show resolved Hide resolved
worlds/aquaria/docs/setup_fr.md Outdated Show resolved Hide resolved
worlds/aquaria/docs/setup_fr.md Outdated Show resolved Hide resolved
worlds/aquaria/docs/fr_Aquaria.md Outdated Show resolved Hide resolved
worlds/aquaria/docs/en_Aquaria.md Outdated Show resolved Hide resolved
worlds/aquaria/docs/en_Aquaria.md Outdated Show resolved Hide resolved
worlds/aquaria/docs/en_Aquaria.md Outdated Show resolved Hide resolved
worlds/aquaria/docs/setup_en.md Outdated Show resolved Hide resolved
@tioui
Copy link
Collaborator Author

tioui commented May 2, 2024

* The link to fr_Aquaria is not available directly on the website. (The page is generated, but not explicitly linked) I suggest doing as [Docs, Starcraft 2: Add French documentation for setup and game page #3031](https://github.com/ArchipelagoMW/Archipelago/pull/3031), but this is not officially sanctioned.

Little question @neocerber. How do you host the web site locally?

@neocerber
Copy link
Contributor

neocerber commented May 2, 2024

* The link to fr_Aquaria is not available directly on the website. (The page is generated, but not explicitly linked) I suggest doing as [Docs, Starcraft 2: Add French documentation for setup and game page #3031](https://github.com/ArchipelagoMW/Archipelago/pull/3031), but this is not officially sanctioned.

Little @neocerber. How do you host the web site locally?

Note: someone gave me these instructions long ago. I do not know if it is the best way to do it.
Ya need to do as instructed in webhost configuration sample.yaml in the docs folder: copy that file, except naming it "config.yaml", in the root of the project. In that file, I had to change port: 80 to port: 8080. Then, simply execute webhost, so python WebHost.py, and access the locally hosted website via http://0.0.0.0:8080/

@nicholassaylor
Copy link
Contributor

* The link to fr_Aquaria is not available directly on the website. (The page is generated, but not explicitly linked) I suggest doing as [Docs, Starcraft 2: Add French documentation for setup and game page #3031](https://github.com/ArchipelagoMW/Archipelago/pull/3031), but this is not officially sanctioned.

Little @neocerber. How do you host the web site locally?

You should also just be able to run WebHost.py after getting the requirements in the WebHost folder. Unless you are hosting a web server on the same PC, port 80 should be fine and then you can connect to it by typing localhost in your browser

@ScipioWright
Copy link
Collaborator

Everyone else is commenting so I wanna comment too -- you can also type in 127.0.0.1 in your browser and that should work too

@tioui
Copy link
Collaborator Author

tioui commented May 2, 2024

It work. Thanks.

@Berserker66 Berserker66 merged commit 89a2a3c into ArchipelagoMW:main May 17, 2024
15 of 16 checks passed
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: new game Pull requests for implementing new games into Archipelago. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants