-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aquaria: implement new game #3197
Conversation
…ation-turtle-check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only looked at the setup and game pages, in French and English. I have never played the game. French is my first language.
General comments:
- The terms randomiser, "randomizer" and randomizer are used in the French part. One of the first two should be chosen.
- The bash command use the wild card *. If multiples versions of the executable/appimage are available, this might cause a problem. You might want to warn the user about that.
- The link to fr_Aquaria is not available directly on the website. (The page is generated, but not explicitly linked) I suggest doing as Docs, Starcraft 2: Add French documentation for setup and game page #3031, but this is not officially sanctioned.
Except for the general and specifics comments, the text of both the setup and game pages (French and English) seems good. I also confirm that the French part corresponds to its English counterpart. I have hosted locally the website and confirms that the links work as intended.
Little question @neocerber. How do you host the web site locally? |
Note: someone gave me these instructions long ago. I do not know if it is the best way to do it. |
You should also just be able to run WebHost.py after getting the requirements in the WebHost folder. Unless you are hosting a web server on the same PC, port 80 should be fine and then you can connect to it by typing |
Everyone else is commenting so I wanna comment too -- you can also type in |
It work. Thanks. |
This is a new world for the Aquaria game (https://www.bit-blot.com/aquaria/).
This is a new world for the Aquaria game (https://www.bit-blot.com/aquaria/).
Aquaria: implement new game
What is this fixing or adding?
This is a new world for the Aquaria game (https://www.bit-blot.com/aquaria/).
How was this tested?
I have personally played the randomizer with all options a couple of times (single world only). There are also two other players that have played multiple run of the game (including multi-world game) and other than some minor logic problems (nothing game breaking), the world and the client appear to be quite solid.
Also, I have created some unit tests to valid important progression logic.