Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete worlds/sc2wol directory #3202

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

ScipioWright
Copy link
Collaborator

@ScipioWright ScipioWright commented Apr 23, 2024

What is this fixing or adding?

It got added back in #2871 unintentionally

How was this tested?

It wasn't

If this makes graphical changes, please attach screenshots.

N/A

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 23, 2024
@ScipioWright ScipioWright added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Apr 23, 2024
Copy link
Collaborator

@hatkirby hatkirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whooee that was a LOT to review but I think I'm satisfied. Next time, though, try splitting this up into separate PRs, okay?

Copy link
Member

@ThePhar ThePhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to ping the world maintainer to review, smh my head.

Good stuff this PR.
image

@ThePhar ThePhar merged commit cca9778 into ArchipelagoMW:main Apr 23, 2024
16 checks passed
@ScipioWright ScipioWright deleted the sc2wol-remove branch April 23, 2024 17:59
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants