Yoshi's World: Fixed minor logic inconsistincy in Rules.py #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
ScipioWright
added
the
waiting-on: world-maintainer
|
for the record, this won't fix the logic, as it'd expect the player get 30 stars without items, which isn't possible so I think not your fault though, current logic is still also wrong (it's just copypaste from the other rules in the level) |
ScipioWright
added
the
waiting-on: author
|
You're absolutely correct @ShinyNT changed my code accordingly to your suggestions. |
PinkSwitch
approved these changes
May 2, 2024
Exempt-Medic
added
the
is: bug/fix
ScipioWright
removed
the
waiting-on: world-maintainer
ShinyNT
approved these changes
May 2, 2024
Exempt-Medic
added
waiting-on: core-review
|
I think you can mark this as no longer a draft |
As of easy logic of this goal is
set_rule(world.multiworld.get_location("GO! GO! MARIO!!: Stars", player), lambda state: logic.has_midring(state) or (state.has("Tulip", player) and logic.cansee_clouds(state)))
normal logic shouldn't need any collectable.
|
Thank's for reviewing and approving. If you're interested in a tracker for this world please check out my little project: |
Exempt-Medic
added
waiting-on: core-review
NewSoupVi
approved these changes
May 4, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
…goMW#3241) * Fixed Logic in Rules.py As of easy logic of this goal is set_rule(world.multiworld.get_location("GO! GO! MARIO!!: Stars", player), lambda state: logic.has_midring(state) or (state.has("Tulip", player) and logic.cansee_clouds(state))) normal logic shouldn't need any collectable. * Corrected Logic Rules.py
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
…goMW#3241) * Fixed Logic in Rules.py As of easy logic of this goal is set_rule(world.multiworld.get_location("GO! GO! MARIO!!: Stars", player), lambda state: logic.has_midring(state) or (state.has("Tulip", player) and logic.cansee_clouds(state))) normal logic shouldn't need any collectable. * Corrected Logic Rules.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of easy logic for this goal is
logic.has_midring(state) or (state.has("Tulip", player) and logic.cansee_clouds(state))normal logic shouldn't need any collectable as
logic.cansee_clouds(state)allways evaluates totruein normal logic and therefore the hole equation istrue. Normal logic shouldn't need more collectables than easy logic.