[TLOZ]: Remove use of per_slot_randoms #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only used it in two spots for randomizing the secret rupee cave values. Uses proper world random now.
t3hf1gm3nt
added
the
is: maintenance
github-actions
bot
added
the
waiting-on: peer-review
t3hf1gm3nt
added
is: refactor/cleanup
|
i swear i'll learn how to use the labeling thing properly one day >.< |
Exempt-Medic
approved these changes
May 2, 2024
NewSoupVi
approved these changes
May 3, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
We only used it in two spots for randomizing the secret rupee cave values. Uses proper world random now.
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
We only used it in two spots for randomizing the secret rupee cave values. Uses proper world random now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
We only used it in two spots for randomizing the secret rupee cave tiers and values. Uses proper world.random now.
How was this tested?
Genned two test seeds, checked two different value secret rupee caves in each seed and confirmed their values were still being randomized as intended.
If this makes graphical changes, please attach screenshots.