Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebHost: use redirect for /room form submission #3271

Merged
merged 1 commit into from
May 5, 2024

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

removes
image
if you enter a command into the bar in /room, then go back/forth via browser controls.

How was this tested?

comparing localhost to archipelago.gg

If this makes graphical changes, please attach screenshots.

Turns
image
into:

@github-actions github-actions bot added affects: webhost Issues/PRs that touch webhost and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels May 5, 2024
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer separate @app.get and @app.post to make it easier to read, but in this case it's not too bad.

@Berserker66 Berserker66 merged commit 2aa3ef3 into main May 5, 2024
26 checks passed
@Berserker66 Berserker66 deleted the webhost_redirect_form branch May 5, 2024 20:59
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: webhost Issues/PRs that touch webhost and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants