Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: remove obsolete yaml generation info #3304

Merged
merged 3 commits into from
May 16, 2024

Conversation

beauxq
Copy link
Collaborator

@beauxq beauxq commented May 15, 2024

What is this fixing or adding?

The line about template yamls from WebHost was added when we didn't have the "Generate Template Options" button in the launcher,
so this was one of the best ways to generate the default yamls.

Even though the information is still accurate, I don't think it's useful enough to keep here anymore.

How was this tested?

on Thursdays

This line was added when we didn't have the "Generate Template Options" button in the launcher.
@github-actions github-actions bot added is: documentation Improvements or additions to documentation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels May 15, 2024
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

Should we mention Launcher.py as the entry point for clients?

Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@black-sliver black-sliver merged commit 4bd4a2c into ArchipelagoMW:main May 16, 2024
3 checks passed
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
* Docs: remove obsolete yaml generation info

This line was added when we didn't have the "Generate Template Options" button in the launcher.

* add information about `Launcher.py`
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
* Docs: remove obsolete yaml generation info

This line was added when we didn't have the "Generate Template Options" button in the launcher.

* add information about `Launcher.py`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants